[MPlayer-dev-eng] [PATCH] libnemesi support in mplayer

[Diego Biurrun]

On Wed, Sep 19, 2007 at 07:03:53PM +0200, Luca Barbato wrote:
> Diego Biurrun wrote:
> > 
> > This is not the way to go.  Add a new variable in config.mak, then make
> > sure that configure only activates either nemesi or that variable.  Then
> > you can remove all those conditionals from the Makefile.
> 
> I see
> 
> >> --- configure	(revision 24576)
> >> +++ configure	(working copy)
> >> @@ -6222,7 +6226,25 @@
> >>  
> >> +if test "$_nemesi" = yes; then
> >> +    _def_nemesi='#define LIBNEMESI 1'
> >> +    _inputmodules="nemesi $_inputmodules"
> >> +    _live=no
> > 
> > Do not disable live555 from the nemesi check, rather have the live555
> > check make sure that nemesi is disabled.
> 
> ok
> 
> I hope I got it right now.

Yes, I'm happy with this now, some small nits below..

> --- stream/Makefile	(revision 24576)
> +++ stream/Makefile	(working copy)
> @@ -28,20 +28,24 @@
>  
> +SRCS_COMMON-$(LIBNEMESI)   	 += stream_nemesi.c
> +
> +
>  SRCS_COMMON-$(PVR)               += stream_pvr.c
>  SRCS_COMMON-$(RADIO)             += stream_radio.c

Please keep the += aligned.

> --- configure	(revision 24576)
> +++ configure	(working copy)
> @@ -6222,7 +6227,25 @@
>  
> +if test "$_nemesi" = yes; then
> +    _native_rtsp=no

Shouldn't live555 disable _native_rtsp as well?

Diego