[MPlayer-dev-eng] [PATCH] Movie fragment support for MOV/MP4 demuxer

[Diego Biurrun]

On Mon, Sep 17, 2007 at 05:33:10PM +0200, David Romacho Rosell wrote:
> En/na Reimar Döffinger ha escrit:
>> On Sat, Sep 15, 2007 at 06:38:26PM +0200, David Romacho Rosell wrote:
>>   
>>> Thanks for your comments. This is the first time I send a patch and, as I 
>>> can see, I will need to spend some more time on the code.
>>
>> And please do not top-post when replying.
>> I do not know how you created the patch, but if you need help with 
>> something it might be
>> better to send a patch against demux_mov.c before I split lschunks, that
>> should already make the changes a bit easier to follow.
>> I should (hopefully) also be reasonably easy to bring that patch then
>> up-to-date with the merging features of e.g. svn or git (though svn is
>> not that great at it and git is a bit complex to use in that regard).
>>
> Thanks for your comments. I am trying to get used to your rules.

You no longer top-post, which is an improvement.  If you want your mails
to be even more welcome, start trimming your quotes a bit.

> I revised the patch so it does not introduce as many changes as the 
> previous one. I also cleaned up the cosmetics. Note that now we have a 
> lschunks_inmfra, lschunks_intraf, lschunks_inmoof, lschunks_inmvex  
> functions, each one processes box/atom needed by the movie fragments. This 
> code could be in lschunks but I think that in that way lschunks does not 
> get a mess.

The patch is still huge and randomly indented with a mix of tabs and
spaces.  Please fix this and try to split it into even smaller chunks.
This will make finding a reviewer for your code much easier.

Diego