[MPlayer-dev-eng] [PATCH] libnemesi support in mplayer

[Luca Barbato]

Diego Biurrun wrote:
> On Thu, Sep 13, 2007 at 07:09:45PM +0200, Luca Barbato wrote:
>> Luca Barbato wrote:
>>> Here is an initial patch to have libnemesi[1] handle rtsp instead of
>>> live555. (you can chose at configure which one to use)
>>>
>> Updated, exposing tcp and sctp alternate transport and fixing some
>> glitches while addressing most of the comments.
>>
>>
>> Known issues: something quite wrong happens if your network doesn't have
>> enough bandwidth, we are still trying to address it in a sane way.
>>
>> Make sure you have a current version of libnemesi since we are trying to
>> address the issues by the time they got reported.
>>
>> --- configure	(revision 24447)
>> +++ configure	(working copy)
>> @@ -6220,7 +6224,27 @@
>>  
>> +echocheck "Nemesi Streaming Media libraries"
>> +if test "$_nemesi" = auto  && test "$_network" = yes ; then
>> +    if $_pkg_config --exists libnemesi ; then
>> +        _ld_extra="$_ld_extra `$_pkg_config --libs libnemesi`"
>> +        _nemesi=yes
>> +    else
>> +        _nemesi=no
> 
> Put this before the if, saves one line.

ok

> 
>> +    fi
>> +fi
>> +echores "$_nemesi"
>>  
>> +if test "$_nemesi" = yes; then
>> +    _def_nemesi='#define LIBNEMESI 1'
>> +    _inputmodules="nemesi $_inputmodules"
>> +    _nemesi=yes
> 
> This line is obviously redundant.

right

> 
>> @@ -6270,7 +6294,6 @@
>>  fi
>>  echores "$_live"
>>  
>> -
>>  echocheck "FFmpeg libavutil"
>>  if test "$_libavutil_a" = auto ; then
>>    if test -d libavutil ; then
> 
> cosmetics

ops...

> 
>> --- libmpdemux/Makefile	(revision 24447)
>> +++ libmpdemux/Makefile	(working copy)
>> @@ -52,6 +52,7 @@
>>  SRCS_COMMON-$(LIBVORBIS)               += demux_ogg.c
>>  SRCS_COMMON-$(MUSEPACK)                += demux_mpc.c
>>  SRCS_COMMON-$(STREAMING_LIVE555)       += demux_rtp.cpp demux_rtp_codec.cpp
>> +SRCS_COMMON-$(LIBNEMESI)               += demux_nemesi.c
>>  SRCS_COMMON-$(WIN32DLL)                += demux_avs.c
>>  SRCS_COMMON-$(XMMS_PLUGINS)            += demux_xmms.c
> 
> Why do people keep adding things in random order?

logic order vs alphabetic.

> 
>> --- libmpdemux/demux_nemesi.c	(revision 0)
>> +++ libmpdemux/demux_nemesi.c	(revision 0)
>> @@ -0,0 +1,384 @@
>> +
>> +// extern int rtsp_port;
>> +
>> +// extern int rtsp_port;
> 
> Debug code?  Please remove them.

Incomplete/untested code, nemesi can/should use the rtsp_port hint too.

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero