[MPlayer-dev-eng] [PATCH] hack to make vd_ffmpeg work with demux_lavf for rm files

Michael Niedermayer michaelni at gmx.at
Sun Sep 16 13:15:28 CEST 2007


On Sat, Sep 15, 2007 at 10:05:26PM +0200, Reimar Döffinger wrote:
> Hello,
> attached is a hack that disables some other hack when lavf demuxer is
> used and thus makes rv decoding work instead of crash.
> 
> Greetings,
> Reimar Döffinger

> Index: libmpcodecs/vd_ffmpeg.c
> ===================================================================
> --- libmpcodecs/vd_ffmpeg.c	(revision 24537)
> +++ libmpcodecs/vd_ffmpeg.c	(working copy)
> @@ -754,7 +754,7 @@
>  
>      avctx->hurry_up=(flags&3)?((flags&2)?2:1):0;
>  
> -//    if(sh->ds->demuxer->type == DEMUXER_TYPE_REAL){
> +    if(sh->ds->demuxer->type != DEMUXER_TYPE_LAVF)
>      if(   sh->format == mmioFOURCC('R', 'V', '1', '0')
>         || sh->format == mmioFOURCC('R', 'V', '1', '3')
>         || sh->format == mmioFOURCC('R', 'V', '2', '0')

ok, btw the slice_offset/slice_count system is broken (thread saftey issues
between demuxer and decoder also it breaks remuxing)
and all traces of it should be removed from both mplayer and
libavcodec

the slice offset (and count?) should be passed together with the bitstream of
the frame, and lavc should be fixed to be able to use this
this would fix remuxing and tread saftey issues
also the lavf demxuer would need to be fixed to store it in the frames

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070916/0a07e7ef/attachment.pgp>


More information about the MPlayer-dev-eng mailing list