[MPlayer-dev-eng] [PATCH] Movie fragment support for MOV/MP4 demuxer

[David Romacho Rosell]

Hi,

Thanks for your comments. This is the first time I send a patch and, as 
I can see, I will need to spend some more time on the code.

 David

En/na Reimar Döffinger ha escrit:
> Hello,
> On Sat, Sep 15, 2007 at 04:37:51PM +0200, David Romacho Rosell wrote:
>   
>> This patch adds support for movie fragments for the mov demuxer. Some 
>> digital cameras produce this kind of files. The original mov demuxer does 
>> not support this feature and only recognises the first movie fragment.
>>
>> This patch implements the movie fragment as especified in the the ISO/IEC 
>> 14496-12 standard.
>>     
>
> 1) Please do not write mails by replying to completely unrelated mails
> 2) Your patch contains cosmetics and unrelated code, worst among those
> reverting the lschunks function into one huge messy function again
> instead of keeping the gen_sh_video/gen_sh_audio functions I split out.
> 3) As long as our mov demuxer is such a mess, a patch adding hundreds of
> lines is not acceptable, so either get this feature down to an
> acceptable and reviewable size or rework the mov demuxer code so it is
> less of a mess. Or alternatively implement support for this in
> libavformat instead (but don't expect the review process to be any
> easier there, it is ffmpeg after all).
>
> Greetings,
> Reimar Döffinger
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>
>