[MPlayer-dev-eng] [PATCH] shmem - stream

[Diego Biurrun]

On Thu, Sep 13, 2007 at 08:06:44PM +0200, Ötvös Attila wrote:
> 2007. szeptember 13. 11.09 dátummal Diego Biurrun ezt írta:
> > On Wed, Sep 12, 2007 at 03:59:49PM +0200, Ötvös Attila wrote:
> > > --- stream/stream_shmem.h	(revision 0)
> > > +++ stream/stream_shmem.h	(revision 0)
> > > @@ -0,0 +1,22 @@
> > > +
> > > +#define SHMEM_RAWREAD   0
> > > +#define SHMEM_MAX_TYPE  0
> > > +
> > > +void set_shmem_opts(int type, int size, int demuxer_type, int format,
> > > int width, int height);
> >
> > Please add standard multiple inclusion guards.
> 
> I add comment.

I don't know what you added, but it was not what I asked for.  I will be
more explicit below:

> --- stream/stream_shmem.h	(revision 0)
> +++ stream/stream_shmem.h	(revision 0)
> @@ -0,0 +1,23 @@
> +/*
> + *  Copyright (C) 2007 Attila Ötvös <attila at onebithq.com>
> + *
> + *  MPlayer is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2, or (at your option)
> + *  any later version.
> + *
> + *  MPlayer is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with MPlayer; if not, write to the Free Software
> + *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */

#ifndef STREAM_SHMEM_H
#define STREAM_SHMEM_H

> +
> +#define SHMEM_RAWREAD   0
> +#define SHMEM_MAX_TYPE  0
> +
> +// set shmem stream properties before open (write mode)
> +void set_shmem_opts(int type, int size, int demuxer_type, int format, int width, int height);

#endif /* STREAM_SHMEM_H */

These are the lines I want you to add to the header file.  They are
called "multiple inclusion guards" because they protect the header file
from being included multiple times (and possibly causing warnings or
errors).

Diego