[MPlayer-dev-eng] [RFC] rc2 at the beginning of October

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Sep 14 15:48:07 CEST 2007


Hello,
On Fri, Sep 14, 2007 at 04:20:25PM +0300, Uoti Urpala wrote:
> On Fri, 2007-09-14 at 15:17 +0200, Reimar Döffinger wrote:
> > On Fri, Sep 14, 2007 at 03:52:51PM +0300, Uoti Urpala wrote:
> > > On Fri, 2007-09-14 at 14:25 +0200, Jindrich Makovicka wrote:
> > > > X86_FXSR_MAGIC is not defined in the userspace headers anymore, which
> > > > disables SSE detection.
> > > 
> > > I think this test can be simply dropped and OS support can be assumed to
> > > exist on Linux. See for example
> > > http://lists.freedesktop.org/archives/mesa-commit/2007-April/000413.html
> > > 
> > > I'll remove the test soon unless someone comes up with a reason not to.
> > > A check for pre-2.4 kernels could be added but I think those are too
> > > ancient to bother.
> > 
> > You mean checking if X86_FXSR_MAGIC is defined in cpuinfo.c? I don't see
> 
> No I mean removing the whole test and always assuming that OS support
> exists on Linux.

I allowed myself to remove the code parts that were not used. The
comments indicate that some (badly configured) 2.4 kernels would still
need the check as well.
Since it is not that much code anymore I'd slightly prefer if we could
leave it in for a while longer, esp. since that is the one of the tests
that comes closest to working with pure posix and might be easiest to
port.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list