[MPlayer-dev-eng] [RFC] rc2 at the beginning of October

[Reimar Döffinger]

Hello,
On Fri, Sep 14, 2007 at 03:52:51PM +0300, Uoti Urpala wrote:
> On Fri, 2007-09-14 at 14:25 +0200, Jindrich Makovicka wrote:
> > X86_FXSR_MAGIC is not defined in the userspace headers anymore, which
> > disables SSE detection.
> 
> I think this test can be simply dropped and OS support can be assumed to
> exist on Linux. See for example
> http://lists.freedesktop.org/archives/mesa-commit/2007-April/000413.html
> 
> I'll remove the test soon unless someone comes up with a reason not to.
> A check for pre-2.4 kernels could be added but I think those are too
> ancient to bother.

You mean checking if X86_FXSR_MAGIC is defined in cpuinfo.c? I don't see
the point of it anyway, if the kernel does not support SSE it should
result in a illegal instruction exactly as on CPUs without SSE or am I
missing something?
So even with 2.2 kernels testing for X86_FXSR_MAGIC seems pointless to
me...

Greetings,
Reimar Döffinger