[MPlayer-dev-eng] [PATCH] bigendian fix for hwac3

[Ulion]

2007/9/14, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Fri, Sep 14, 2007 at 01:16:01AM +0800, Ulion wrote:
> [...]
> > If we want to prevent byte-swap twice both in hwac3 and ao module and
> > place all byte-swap code in one place (hwac3), we have to make hwac3
> > known accurate byte-order of the output stream.
>
> No, you can teach af_format the conversion between BE and LE AC3
> (which luckily is exactly the same as for normal 16 bit audio) and make
> hwac3 always output whatever the input is, and just make it add the
> headers (in the right endianness for the input data format - the
> simplest way to do this is probably to always write the headers in
> native endian and swab them if the format passed through has different
> endianness - swapping 8 bytes hardly uses any CPU).
>

Sounds good. But more modifications needed in more than one files. I
think currently swab version or word assign version from you is quite
enough for resolve current problem of bigendian passthrough. The
resolution of af_format convert can be implemented in the future if
needed, do you agree with this?

Here's the fixed (a little bug) word assign version and tested on G5
native compile.

-- 
Ulion
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hwac3_bigendian_wordassign.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070914/e9ac35c6/attachment.txt>