[MPlayer-dev-eng] [PATCH] some more warning fixes

[deganews]

Diego Biurrun wrote:
[snip]
> -            if (c == '[' || c == 'O' && getch2_len >= 3) {
> +            if (c == '[' || ( c == 'O' && getch2_len ) >= 3) {
[snip]

This change seems suspicious. Should this not be:

       if ((c == '[' || c == 'O') && getch2_len >= 3) {

Note that (c == 'O' && getch2_len) always evaluates to 0 or 1,
so (c == '[' || (c == 'O' && getch2_len) >= 3) becomes
(c == '['), which is probably not the desired behaviour.

Cheers,