[MPlayer-dev-eng] [PATCH] shmem - stream

[Vladimir Voroshilov]

2007/9/12, Ötvös Attila <oattila at chello.hu>:
> > > Hi Vladimir Voroshilov!
> > ...  and "find ten differences" (c)
> >
> > You'll should only change HAVE_SHMEM to HAVE_SHM,
> > add "SHM=$_shm" in proper place into configure and change $(SHMEM) to
> > $(SHM) in your make files.
>
> Hi Vladimir Voroshilov!
>
> The HAVE_SHM used with video driver (vo_xvmc, vo_x11, vo_xv).
>
> If shared memory stream depend shm check is user don't separate:
> video shm (--enable-shm/--disable-shm),
> shared memory stream (--enable-shmem/--disable-shmem).

I can't translate this sentence

> Do I make depend?

I don't undestand.


I'm 99.99% sure that Diego will reject such code duplication.
If you want configure option do disable shared memory stream only (why?) then
create apropriate (properly named!) option (like
--enable/disable-shmem-stream) and make it dependant on $_shm (i.e.
disable it if SHM is not detected/disabled).
But don't add 100% equal code into configure.



-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719