[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[Ulion]

2007/9/11, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Sep 09, 2007 at 07:43:37PM +0800, Ulion wrote:
> > ignored?
>
> Well, I am not really the maintainer of the input stuff, but I very much
> dislike that it duplicates the double-click code in mp_fifo.c, and in
> addition with a slightly different behaviour I think...
>
> Greetings,
> Reimar Döffinger

Thanks for reply.
I known what you mean. But there are some reason I did not use mp_fifo:
1. First of all, the mp_fifo has no event timestamp, check doubleclick
highly depends on the timestamps of event, specially Apple Remote
(which got events by a loop check, use the time we got the event is
not accurate.).
2. mp_fifo's doubleclick check code now is only used for mouse
doubleclick check. It's there mainly because each vo module got mouse
event by different method, for a common way to get doubleclick event
from different vo modules, mp_fifo was intraduced.
3. mp_fifo will send out all events even if it's one click of a
doubleclick event. This is not we expected. If it's a doubleclick, we
need not any single click event, these need codes to delay event and
resend event out depends whether it's a doubleclick. Since Apple
Remote currently only for apple darwin platform, it's not worth to
make mp_fifo so complex, by now keep the ar-doubleclick code only in
ar.c is a good choice.

And, here's the missed patch for last reply to Diego's, only comments fix.


-- 
Ulion
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: apple_remote_double_click2.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070911/8ed2b469/attachment.txt>