[MPlayer-dev-eng] [PATCH] tv:// for win32

Vladimir Voroshilov voroshil at gmail.com
Sat Sep 8 20:19:31 CEST 2007


Hi, Reimar

2007/9/8, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Sep 08, 2007 at 11:07:37PM +0700, Vladimir Voroshilov wrote:
> > 2. dshow_core_hdr_v96.diff.gz
>
> Name starting with _ are reserved, do not use them if it can be avoided.
> Esp. don't use them for the include guards.

Fixed in local version.

> > 3. dshow_core_v96.diff.gz
>
> The "Changelog" does not belong there at all, and the Abilities/Known
> Bugs etc. belong in the documentation, not in the code.

I'll remove it before commit, of course.

> A proper review will hopefully follow some other day soon... ;-)

I'll wait

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list