[MPlayer-dev-eng] [PATCH] crash in pullup with invalid filters

Rich Felker dalias at aerifal.cx
Sat Sep 8 15:29:33 CEST 2007


On Fri, Sep 07, 2007 at 02:47:26PM -0400, Alexander Strange wrote:
> -vf pullup will crash if it's in a filter chain (like -vf  
> pullup,format=yuy2,crop) that can't init.
> This is because pullup_free_context() doesn't check for c->head being  
> NULL.
> Attached patch fixes it.

At first I thought this was a bad approach and should be done in
vf_pullup.c instead, but now I see the problem is that pullup.c fails
to correctly free a context which has been allocated but not
initialized. So, looks up to me. Anyone reading feel free to apply. :)

Rich



More information about the MPlayer-dev-eng mailing list