[MPlayer-dev-eng] [PATCH] support setting lavc low delay encoding

[Michael Niedermayer]

Hi

On Thu, Sep 06, 2007 at 11:10:48AM +0200, Reimar Döffinger wrote:
> Hello,
> On Thu, Sep 06, 2007 at 12:14:13AM +0200, Michael Niedermayer wrote:
> > On Tue, Sep 04, 2007 at 12:49:21PM +0200, Reimar Döffinger wrote:
> > > I had this patch lying around. I don't consider it too useful, but it's
> > > not much code.
> > > Do you think it is okay to apply?
> > 
> > ok
> 
> Applied.
> 
> > btw, how much time do you think people have spend adding one option after
> > the other by hand? do you think it was more than adding AVOption support?
> 
> Well, for the individual person, in percent of their free time: Yes, I
> think so. We are stuck in a local minimum so to say...
> I think that the AVOption approach would be quite messy in the beginning
> because we use different option names.

well, i didnt suggest to remove the current parsing code, just to try
AVOption for unknown options ...
the existing options could the slowly be removing where possible, but
that would be a seperate thing ...


> And lastly, who except a few select ffmpeg developers even know how the
> AVOption stuff works (or can find out without reading the source). It's
> not at all like you can just throw our unparsed string at some function
> and it will do the magic...

no but its pretty close ...
just split it in option=value pairs and pass to 
av_set_string(video_context, ...)
av_set_string(audio_context, ...)

optionally first checking with av_find_opt() that the option is marked as for
the specific context that is has AV_OPT_FLAG_VIDEO_PARAM before calling
av_set_string(video_context, ...)

and second optionallity is that if no mathing option is found and the string
starts with v,a,s then retrying without that and just the video/audio/subtitle
context

this needs ~20 lines of code in ffmpeg.c and iam sure you could write it
in less :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070907/1f099a69/attachment.pgp>