[MPlayer-dev-eng] [PATCH] af_scale* command-line only

[Scott Lamb]

Robert,


Thanks for doing this af_scale* work. It is extremely useful for 
listening to lectures. I tried out your June 13th patch. [1] Is this the 
latest version?

(Sorry for the new thread; I wasn't subscribed to this list at the time, 
and the web archives do not show message IDs.)

 > Any feedback?  Do they compile?  Run?  Crash?  Contain silly code?

Haven't looked closely at the code, but I compiled and ran it, applied 
against latest mplayer trunk (revision 24356). Here's what I found:

* on first run of "mplayer -af scalepitch=1.5 speed=1.5 file.avi", it 
crashed somewhere in audio decoding. Unfortunately, I had not compiled 
with --enable-debug, and when I did the error went away. So no useful 
stack trace, and I don't even know for sure your patch is at fault. I 
can let you know if it pops up again.

* I don't understand the point of scaletempo= or scalerate=.

* scalepitch= sounds great and almost does what I want:

** it seems to *increase* the pitch by the given factor, so when used 
with -speed, the numbers need to be reciprocals to maintain the original 
pitch. E.g., I am running it with the rather ugly command "mplayer -af 
scalepitch=.76923076923076923076 -speed 1.3 file.avi". It would be more 
convenient if I didn't have to use a calculator to generate the correct 
command.

** an "-af scalepitch_auto" filter (like the "-af scaletempo_auto" you 
had in the previous patch set) that follows my "[" and "]" keypresses 
would be extremely useful. With it, people could take advantage of this 
feature without even being conscious of it, which I think is the ideal 
thing.

Best regards,
Scott

[1] - 
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-June/052464.html

-- 
Scott Lamb <http://www.slamb.org/>