[MPlayer-dev-eng] [PATCH] change screen of GUI window

[Reimar Döffinger]

Hello,
On Wed, Sep 05, 2007 at 11:04:31PM +0200, Diego Biurrun wrote:
> On Fri, Aug 31, 2007 at 02:07:50AM +0200, Rodrigo wrote:
> > 
> > First of all, this is my first patch to mplayer, but I hope it'll be
> > useful...
> 
> You seem to have avoided all the glaring first-timer mistakes, congrats.
> 
> > This patch applies only to the GUI & X11 version. 
> > 
> > --- DOCS/man/en/mplayer.1	(revisión: 24305)
> > +++ DOCS/man/en/mplayer.1	(copia de trabajo)
> > @@ -2758,6 +2758,10 @@
> >  .
> >  .TP
> > +.B \-guiscreen <n> (X11 and GUI only)
> 
> The GUI depends on X11 anyway, so this should just be (GUI only).
> 
> > +Moves the GUI window from the default display screen to the specified.
> > +It can only change between screen belonging to the same display.
> 
> I think an example would be good here.
> 
> Any more thoughts on this patch?  I'm tempted to apply it.

You can't make the Gui a more unmaintainable mess than it is and no
developer cares about it.
That means that
a) I don't really consider it worth adding new features to the Gui
b) But anyone who wants to do it anyway: feel free to make the Gui code
your personal playground. But if you break it too much you must fix it
again :-P
The only thing that might be tricky here is to check that the default
behaviour remains the same as the current one.

Greetings,
Reimar Döffinger