[MPlayer-dev-eng] [PATCH] Let vo directx survive screensaver

Zuxy Meng zuxy.meng at gmail.com
Thu Oct 25 04:22:07 CEST 2007


Hi,

2007/10/23, Zuxy Meng <zuxy.meng at gmail.com>:
> Hi,
>
> 2006/12/7, Sascha Sommer <saschasommer at freenet.de>:
> > Hi,
> >
> > On Saturday 02 December 2006 17:42, Zuxy Meng wrote:
> > > Hi,
> > >
> > > 2006/12/3, Sascha Sommer <saschasommer at freenet.de>:
> > > > Hi,
> > > >
> > > > get_image updates the pointers to the image in the mpi struct. The codecs
> > > > will use this struct to render the image. They won't call any additional
> > > > vo directx functions. With your patch they stay the same when Lock()
> > > > failed. But the pointers are not valid after the directx Unlock() even if
> > > > they happen to work.
> > > >
> > > >
> > > > I'm not sure if these issues are worth fixing. I cannot even reproduce
> > > > the crash but if you come up with a clean solution for this feel free to
> > > > update the patch.
> > >
> > > Hmm, seems not too hard a task to do. Maybe I can just merge parts of
> > > my patch to yours, replacing image with a dedicated static var.
> >
> > Yes that should be possible.
>
> Sorry for the late response...I was a bit too busy and nearly forgot
> about it. But could u pls review the attached patch? It combines good
> from both.

If no one objects I'll apply it this weekend.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list