[MPlayer-dev-eng] [PATCH] [MPlayer OSX] Support open another file while playing

Ulion ulion2002 at gmail.com
Wed Oct 24 06:44:34 CEST 2007


2007/10/23, Diego Biurrun <diego at biurrun.de>:
> On Tue, Oct 23, 2007 at 11:01:40PM +0800, Ulion wrote:
> >
> > To make new task not affect by previous task's notification, we need
> > to remove observers before start new task. Here's the patch.
>
> some nits below..
>
> > --- Sources/Classes/MplayerInterface.m        (revision 140)
> > +++ Sources/Classes/MplayerInterface.m        (working copy)
> > @@ -874,7 +874,10 @@
> >               [self stop];
> > +             // Remove observers to not recieve notifications.
>
> recEIve

Which copied from some place of that file, fixed.

>
> > @@ -959,10 +962,16 @@
> >
> > +     // Task only terminate once.
>
> Terminate task only once.
>

Fixed.

I also made some test on intel mac platform, the reopen operations
sometimes crash MPlayer OSX, in the log it said:

> MPlayer OSX[489] Failed to get shared memory id from mplayer (shmget)

After some test, I think this patch also fix the crash problem.

Here's the comment fixed patch.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayerosx_reopen_fix2.diff
Type: application/octet-stream
Size: 1191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071024/ccf6b2bf/attachment.obj>


More information about the MPlayer-dev-eng mailing list