[MPlayer-dev-eng] [PATCH] Fix osd stuck bug on Darwin platform

Guillaume POIRIER poirierg at gmail.com
Tue Oct 23 00:48:47 CEST 2007


Hi,

On 10/22/07, Ulion <ulion2002 at gmail.com> wrote:
> Hello,
>
> Finally, I found the reason caused osd stuck on mac os x, it's the
> GetTimerMS() function in osdep/timer-darwin.c, this is the current
> code:
>
> unsigned int GetTimerMS()
> {
>   return (unsigned int)(GetTimer() / 1000);
> }
>
> the GetTimer() return type is unsigned int, as the microseconds, it
> will overflow after system startup for 4294.967296 seconds. Then the
> return value of GetTimerMS() will be wrong, and will be not continual
> every 4294.967296 seconds. The un-continual return value from
> GetTimerMS() will cause the osd stuck bug. So I made a patch for it
> here.

Tested on a full 1h50 movie tonight. No problem during playback this time.
I'll try to test your patch on another sample tomorrow, or the day after.

Good!

Guillaume
-- 
A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte



More information about the MPlayer-dev-eng mailing list