[MPlayer-dev-eng] [PATCH] find_sub bugfix when sub switched

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Oct 21 14:13:00 CEST 2007


Hello,
On Sun, Oct 21, 2007 at 01:59:31PM +0200, Reimar Döffinger wrote:
> On Thu, Oct 11, 2007 at 10:08:38PM +0800, Ulion wrote:
> > I found a bug of find_sub, it has two static variables
> > nosub_range_start and nosub_range_end. These two variables did not be
> > reset when sub stream switched, here's the fix patch and test case
> > (two srt, the first sub stream will invisible until the first sub time
> > of second sub stream after switched to the second substream and
> > switched back.)
> 
> Seems like a somewhat ugly way to fix it (assuming that subd pointer
> changes and not just the data), but I currently have no better idea.
> Anyone else?

And if you haven't done so read DOCS/tech/svn-howto.txt and if you agree
with the policy please contact Diego to get a SVN account.
Please note that MPlayer accounts traditionally come with permissions
for FFmpeg SVN as well, take care not to tread on their territory
without a mail on ffmpeg-dev (libav*, libpostproc and libswscale belong
to FFmpeg). Hmm.. This may be worth adding to svn-howto.txt...
If you have any pending patches you consider good enough for SVN you can
then apply them after giving a warning and about a day of additional time
for objections.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list