[MPlayer-dev-eng] [PATCH]

[Diego Biurrun]

On Sat, Oct 20, 2007 at 03:34:45PM +0200, A Mennucc wrote:
> 
> recently I received a patch by Dann Frazier, as part of Debian bug
> 447278 ; the problem is in tremor, where  _vorbis_block_alloc()
> is used w/o proto in some code, and this will crash in ia64; details  in
>  http://wiki.debian.org/ImplicitPointerConversions
> 
> IMHO this patch may be applied to SVN as well
> 
> --- mplayer-1.0~rc2~/tremor/block.h	1970-01-01 01:00:00.000000000 +0100
> +++ mplayer-1.0~rc2/tremor/block.h	2007-10-19 20:57:44.000000000 +0200
> @@ -0,0 +1,23 @@
> +
> +#ifndef _V_BLOCK_H_
> +#define _V_BLOCK_H_

Note that this is against the C standard, underscore and capital are
reserved for system use.  Yes, everybody and his brother does this
wrong.  But there is no point in changing this in a single file of this
library, so we shall leave it for now.

Diego