[MPlayer-dev-eng] [PATCH] libass - fix text aspect w/ panscan and vo_gl

Evgeniy Stepanov eugeni.stepanov at gmail.com
Fri Oct 19 20:41:59 CEST 2007


On Wednesday 10 October 2007 14:51:32 Jindrich Makovicka wrote:
> Could we make this behavior tunable by some option, like 1) fixed
> position for all (your way), or 2) fixed for \pos and \move, keep
> others on screen (my preference), or 3) keep everything on screen?

I've committed something like the 3rd variant.

Second variant requires some work. We would need a separate x2scr_ function, 
and then we have to go through all uses of x2scr and decide if it is used for 
positioned subs or not. Many of them are used for both, so we'll need 
an 'if', bloating the code.

Another argument against it: there is no strict distinction between these 2 
kinds of subs. Sometimes subs are placed in the middle of the screen simply 
by setting a large margin value. Though it is a rare occasion.

And even though positioned subtitles are usually tied to a specific point in 
the video, you may still want to be able to read it, even if it is slightly 
off.

Having said all this, I won't mind a patch implementing 2nd variant, triggered 
by some option, or not. I think, -ass-use-margins could be used for this: by 
default subtitles are displayed strictly on video, with this option they are 
tweaked to better use the available screen space.



More information about the MPlayer-dev-eng mailing list