[MPlayer-dev-eng] [PATCH] fix numerous const issues in libmpcodecs

[Reimar Döffinger]

Hello,
On Thu, Oct 18, 2007 at 03:58:34PM -0400, Rich Felker wrote:
> @@ -43,7 +43,7 @@
>  static unsigned int find_best(struct vf_instance_s* vf){
>      unsigned int best=0;
>      int ret;
> -    unsigned int* p=bgr_list;
> +    unsigned const int* p=bgr_list;

const in front for consistency would be nicer.


> Index: libmpcodecs/vf.c
> ===================================================================
> --- libmpcodecs/vf.c	(revision 24811)
> +++ libmpcodecs/vf.c	(working copy)
> @@ -24,84 +24,84 @@
>  #include "libvo/fastmemcpy.h"
>  
>  extern vf_info_t vf_info_vo;
> -extern vf_info_t vf_info_rectangle;

Did you forget to change vf_info_vo or did you just not get that far?

> Index: libmpcodecs/vf_2xsai.c
> ===================================================================
> --- libmpcodecs/vf_2xsai.c	(revision 24811)
> +++ libmpcodecs/vf_2xsai.c	(working copy)
> @@ -16,6 +16,8 @@
>  #define uint16 unsigned short
>  #define uint8 unsigned char
>  
> +/* FIXME: these all belong in the context, not as globals! */
> +
>  static uint32 colorMask = 0xF7DEF7DE;
>  static uint32 lowPixelMask = 0x08210821;
>  static uint32 qcolorMask = 0xE79CE79C;

Just put that in an extra commit ;-)
As long as it compiles, I think it can't hurt to apply right away.

Greetings,
Reimar Döffinger