[MPlayer-dev-eng] [PATCH] fix numerous const issues in libmpcodecs

Ivan Kalvachev ikalvachev at gmail.com
Fri Oct 19 00:40:44 CEST 2007


2007/10/18, Rich Felker <dalias at aerifal.cx>:
> MPlayer has LOTS of issues with constant data tables which are not
> declared const. While this might or might not have impact on its
> memory usage (probably small if any), it's very unclean and makes it
> hard to use tools like 'size' to identify modules which are
> incorrectly using real global variables instead of per-context data.
>
> The attached patch is the initial work towards fixing the problem in
> libmpcodecs. I'm submitting it now for comments before I go to lots
> more work, only to have someone bitch about why it's bad.. :) So
> please comment now. And if anyone would like to volunteer to finish
> the job so I don't have to, I'd be quite happy with that too. :))

Is there situation when vf_info_t would be variable and not constant?
(dynamic plug-ins?)
If not, you can define the type as const and make the patch much smaller.



More information about the MPlayer-dev-eng mailing list