[MPlayer-dev-eng] ctype.h functions on win32

[Aurelien Jacobs]

On Sun, 14 Oct 2007 01:01:18 -0400
Rich Felker <dalias at aerifal.cx> wrote:

> On Sun, Oct 14, 2007 at 06:33:25AM +0200, Gianluigi Tiesi wrote:
> > pls try attached patches (splitted mp/lavc/lavf)
> > I leaved as is all ints that come from fgetc since
> > it's supposed to be ok
> > changed chars to unsigned chars where needed
> > (and also in other similar functions for conformance)
> > cast to uint8_t/uchar(in input.c uint8_t not defined)
> > when the source of the value it's not so clear
> > (at least for me of course :D)
> > 
> >  static int
> > -vobsub_parse_timestamp(vobsub_t *vob, const char *line)
> > +vobsub_parse_timestamp(vobsub_t *vob, const unsigned char *line)
> >  {
> >      // timestamp: HH:MM:SS.mmm, filepos: 0nnnnnnnnn
> > -    const char *p;
> > +    unsigned const char *p;
> >      int h, m, s, ms;
> >      off_t filepos;
> >      while (isspace(*line))
> 
> Looks ok.

This one looks inconsistent ("unsigned const" vs. "const unsigned").

Aurel