[MPlayer-dev-eng] [PATCH] add lavfdopts cryptokey

[Michael Niedermayer]

Hi

On Tue, Oct 09, 2007 at 05:11:52PM +0200, Reimar Döffinger wrote:
> Hello,
> On Tue, Oct 09, 2007 at 04:20:05PM +0200, Michael Niedermayer wrote:
> [...]
> > btw, what about doing the hexstring->binary conversion in the codec?
> > this seems a little simpler alseo
> > AVOptions do support strings ...
> 
> hexstring is not a "native" format for keys, that's why I find that
> conversion more natural in the interface code.
> Doing the conversion in the demuxer would also mean that playback
> applications that read the encrypted key from an XML file, decrypt it
> then with a public key algorithm would then have to convert it to a
> string again (this XML thingy is how it seems to be done for MXF often).
> If you are only thinking of support via AVOptions, maybe adding support
> for binary data array + length would maybe not be such a bad idea (though not
> sure if it would be hackish due to having to fill two struct members), it would
> allow overriding e.g. extradata for testing (or is that something that no-one
> really needs? ;-) )

iam not against binary data AVOption, a patch is welcome which would
make AVOption take a hex string and convert that to binary and length
and store these in the 2 corresponding struct fields
lets hope this can be done with no memleak issues ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071010/6666cee8/attachment.pgp>