[MPlayer-dev-eng] [PATCH] libass - fix text aspect w/ panscan and vo_gl

[Evgeniy Stepanov]

On Saturday 06 October 2007 21:41:27 Jindrich Makovicka wrote:
> On Sun, 30 Sep 2007 21:23:44 +0400
>
> Evgeniy Stepanov <eugeni.stepanov at gmail.com> wrote:
> > This patch does not change logical to screen coordinates mapping.
> > This way, for instance, a subtitle with \pos(0, 0) will always be
> > placed at the left-top corner. This is wrong, subtitles placement
> > (relative to the video) should not change with panscan, even if they
> > will sometimes move outside the screen.
>
> This one should handle \pos and \move correctly.

Sorry for the delay, I'm quite busy lately.

With the latest patch positioned subs are sometimes cropped and sometimes not, 
and everything else (top and bottom subtitles) is never cropped (they occupy 
more lines instead). I don't think we should handle positioned subtitles 
differently here.

There is probably some misunderstanding. To me, the correct behavior is the 
one observed with vf_ass + vo_xv. Subtitles are never deformed or moved 
relative to the original video frame. Exactly like if they were encoded into 
the movie (hardsubbed). If you scale it up too much, parts of them will go 
outside the screen and will be cropped.

Implementing the same with vo_gl is very simple. I didn't do much testing, but 
it seems there is nothing in the code that could not handle negative margin 
sizes. Therefore, we could have vo_gl pass exact margin sizes (like in the 
first part of your patch), negative when the image is cropped. No changes to 
libass are required.

What do you think of this idea ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-diff
Size: 597 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071010/c131dad3/attachment.patch>