[MPlayer-dev-eng] [PATCH] add lavfdopts cryptokey

[Reimar Döffinger]

Hello,
On Mon, Oct 08, 2007 at 08:10:33PM +0200, Baptiste Coudurier wrote:
> Reimar Döffinger wrote:
> > On Mon, Oct 08, 2007 at 07:58:41PM +0200, Baptiste Coudurier wrote:
> >> Reimar Döffinger wrote:
> >>> something similar to this is needed to allow playback of encrypted MXF
> >>> (and in the future ASF) files.
> >>> Is it okay to apply as is or does it need changes?
> >> Maybe an API in libavformat is worth, we might have the same code in
> >> ffmpeg/ffplay.
> > 
> > API for hexstring to uint8_t array conversion? I admit I didn't check,
> > it might even be there already. Or what do you mean?
> 
> Yes, kinda. I was thinking of av_set_crypt_key, setting key/keylen,
> because I have the exact same patch for ffmpeg.c, but it might not be
> worth it.

I am not entirely opposed, but currently it seems a bit overkill. If we
really support some more unusual encryption stuff (e.g. per track keys) a
properly designed API for setting and handling the keys will be
necessary but it seems a bit too early for that kind of thing to me.
Can someone think of any other place where we use hexstring/byte array
conversion already? I didn't see any at first glance, so no idea if
something like that would be appropriate to put into libavutil.

Greetings,
Reimar Döffinger