[MPlayer-dev-eng] [PATCH] af_scaletempo

[Uoti Urpala]

On Sat, 2007-10-06 at 21:35 +0200, Reimar Döffinger wrote:
> On Sat, Oct 06, 2007 at 10:26:01PM +0300, Uoti Urpala wrote:
> > I think it's better to fix some of the general filter issues before
> > adding the filter. It buffers more data internally than than the
> > existing resample filters. The following are some issues I think should
> > be fixed in or before the first version that adds the filter:

> > I haven't done those yet mainly because of the release plans.
> 
> Would any of these need major changes to af_scaletempo? I not, I don't
> really see why they should hold this up. And as I understood some
> comments it is at least usable (even if buggy) without these as well.

The changes needed should not be major. However I think that as long as
it triggers problems elsewhere its usefulness is limited enough not to
justify adding it in known buggy state. The issues that I mentioned
should not need so much work that fixing them first would cause a major
holdup (without the release I would have fixed some of them already).
Committing the filter to svn first would not make fixing them any easier
either.