[MPlayer-dev-eng] [PATCH] af_scaletempo

[Uoti Urpala]

On Fri, 2007-10-05 at 22:11 +0200, Reimar Döffinger wrote:
> Hello,
> On Thu, Oct 04, 2007 at 08:19:17PM -0400, Robert Juliano wrote:
> > So, what do I have to do to get someone to commit this?
> 
> I'll try to find time to test it this weekend and the apply it (minus
> cosmetics to mplayer.c).
> If anyone has objections against this please speak up (note I do not
> claim it to be perfect, but if there are issues remaining I think they
> will be easier to fix after applying).

I think it's better to fix some of the general filter issues before
adding the filter. It buffers more data internally than than the
existing resample filters. The following are some issues I think should
be fixed in or before the first version that adds the filter:

- make the final audio buffer before ao dynamically sized like all the
filter buffers
- remove the rational number input/output ratio fields from filters and
replace them with floats (the rationals can overflow and the values do
not need to be exact)
- enable the filter delay logic again and dynamically set the delay
value in af_scaletempo after each call
- when used for runtime playback speed adjustment, make sure
af_scaletempo never alters the audio when input and output rate are
identical, either by rebuilding the filter chain without it or by logic
inside the filter

I haven't done those yet mainly because of the release plans.