[MPlayer-dev-eng] [PATCH] forked code may not use GUI

[A Mennucc]

hi

there was a discussion long ago regarding  bug
http://bugs.debian.org/396962

at that time, Reimar proposed a simple and effective patch
(see  message below) but that
unfortunately would break mencode compilation

I have revised his idea, see attached patch

a.


Reimar Döffinger ha scritto:
> Hello,
> On Sat, Jan 27, 2007 at 11:15:30AM +0100, Reimar D?ffinger wrote:
>> On Sat, Jan 27, 2007 at 10:30:30AM +0100, A Mennucc wrote:
>>> So the reason that my patch for threaded caching works is that it is
>>> possible to open dialog windows from different threads.
>>>
>>> possible solutions:
>>>
>>> 1) make sure you do not ever ever display a dialog from the caching code
>>> 2) use pthreads
>>>
>>> I would suggest the 2nd  :-)
>>> (as I explained in my other email, mplayer is already compiled to use
>>> pthreads in linux)
>> 2) is not a solution to this problem it is a hack-around (or in German:
>> a Würgaround).
>> I think your suggestion has merits, but this problem is not one of them!
>> Actually, I consider hiding a bug a point against a patch.
> 
> Except that it breaks mencoder linking, attached patch is closer to a
> proper fix for that problem.
> 
> Greetings,
> Reimar Döffinger
> 

(I deleted the attached patch of Reimar to avoid confusion - what
follows is mine)

a.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fork-and-gui.diff
Type: text/x-patch
Size: 1022 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071006/9ee60d6c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071006/9ee60d6c/attachment.pgp>