[MPlayer-dev-eng] [PATCH] Make vo_macosx support double buffering by default

[Tim Wojtulewicz]

On Oct 4, 2007, at 5:05 PM, Compn wrote:

> On Fri, 5 Oct 2007 00:17:49 +0800, Ulion wrote:
>
>>> Is it supposed to get rid of some of the flickering effects on OSD?
>>
>> I notice the flickering problem before, but today I did not found
>> flickering with or without double buffering. So that problem may
>> already be fixed, or be fixed by this patch, or still there, not  
>> sure.
>
>
> does double buffering help anything? is it slower? faster?
> prevent tearing? does vo macosx need it?
>
> btw any idea about osd frozen on screen with vo quartz/macosx ?
> it seems to happen when a movie is paused and screen blanks due to
> inactivity and then resume playing movie.
>
> i made this bug for it:
> http://bugzilla.mplayerhq.hu/show_bug.cgi?id=756

I have another vo_macosx issue for you.  I'm getting an intermittent  
crash when passing more than one file to mplayer.  The crash happens  
during the reinit of the vo as far as I can tell.  The problem is  
that I can't seem to reproduce it reliably.  The backtrace from gdb is:

#0  0x90a40100 in objc_msgSend ()
#1  0x0003f748 in preinit (arg=0x252dd20 "\002U?\v") at vo_macosx.m:311
#2  0x00033598 in init_best_video_out (vo_list=0x0) at video_out.c:322
#3  0x000056a8 in reinit_video_chain () at mplayer.c:1899
#4  0x00008094 in main (argc=5832704, argv=0x5a0000) at mplayer.c:3225

I've gotten it to happen with a number of different files (mostly  
xvid and wmv9) so I don't think it's any specific file.  I haven't  
opened a bug on bugzilla for it yet.

Tim