[MPlayer-dev-eng] [PATCH] Make vo_macosx support double buffering by default

[Ulion]

2007/10/4, Guillaume POIRIER <poirierg at gmail.com>:
> Hello,
>
> On 10/4/07, Ulion <ulion2002 at gmail.com> wrote:
> > Hello,
> >
> > > P.S.: My next suggestion for you to improve MPlayer on Mac OS X: Make
> > > vo_macosx support double buffering by default.
> >
> > As Diego suggested, I made a patch for vo_macosx support double
> > buffering by default here.
>
> What is the status of current implementation? Is double buffering just
> not implemented, or broken?

Not implemented, since it use the defaultPixelFormat from
NSOpenGLView. I tested the pixelformat, it does not support double
buffering.

>
> Also, what's a good test case for your patch?

When NSView do double buffering, glFlush should not be called, should
call flushBuffer method of glContext.
When I changed the pixelformat, I got a blank screen output with
glFlush. After call flushBuffer on glContext, I got correct output
display. I think this means the double buffering is working.

>
> Is it supposed to get rid of some of the flickering effects on OSD?

I notice the flickering problem before, but today I did not found
flickering with or without double buffering. So that problem may
already be fixed, or be fixed by this patch, or still there, not sure.


-- 
Ulion