[MPlayer-dev-eng] [PATCH] Fix crash when using win32 codecs on mac osx / intel

Diego Biurrun diego at biurrun.de
Tue Oct 2 00:56:19 CEST 2007


Ulion wrote:
> 2007/9/30, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> 
>>On Sun, Sep 30, 2007 at 05:56:41PM +0800, Ulion wrote:
>>
>>>How about this comment:
>>>
>>># GCC 4.2 and some earlier Apple versions support this flag on x86. It is needed
>>># due to the different ABI OSX/Intel has from windows. But the current gcc will
>>># create wrong code with this flag which described in the blog
>>># http://www.dribin.org/dave/blog/archives/2006/12/05/missing_third_param/
>>># This problem can be worked around by adding cflag -fno-unit-at-a-time.
>>># Now we are trying to find the correct way to use this flag.
>>
>>Seems good to me.
> 
> Then here's the comment updated patch.

I applied it with some small changes and a (hopefully) better phrasing 
of the above paragraph.

Diego




More information about the MPlayer-dev-eng mailing list