[MPlayer-dev-eng] [PATCH] Fix crash when using win32 codecs on mac osx / intel

[Diego Biurrun]

On Sun, Sep 30, 2007 at 03:08:39PM +0800, Ulion wrote:
> 2007/9/30, Diego Biurrun <diego at biurrun.de>:
> > On Sat, Sep 29, 2007 at 10:47:23PM +0200, Diego Biurrun wrote:
> > > On Tue, Sep 25, 2007 at 09:40:36PM +0800, Ulion wrote:
> > > >
> > > > [...]
> > >
> > > I've created a cleaned-up and more compact version of your patch.
> > > Please test it and verify that it works, then I will commit it.
> >
> > Ahem ...
> 
> I tested, and here's some fix:
> 
> >  + if linux && test "$cc_vendor" = "gnu" ; then
> 
> It must be a miss typing.

Yes, typo or leftover from me testing on Linux :)

> Another problem, the 'A && B || C && D' is buggy or not worked as we
> normally expected.
> if A && B got true, no matter whether C is true or false, D always be
> checked (executed). That probably means the shell thought it is 'A &&
> (B || C) && D'.
> So we should avoid check conditions in such form, just try to avoid
> using '&&' after a '||'.
> I make a fixed patch here, and tested ok.

Umm, it sure seems to work here:

cerebus:~$ true && false || false && true; echo $?
1

Diego