[MPlayer-dev-eng] [PATCH] [TEST FUNC] Multi-channel reorder function

[Ulion]

2007/11/29, Ulion <ulion2002 at gmail.com>:
> 2007/11/29, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Thu, Nov 29, 2007 at 10:12:10AM +0800, Ulion wrote:
> > > 2007/11/29, Corey Hickey <bugfood-ml at fatooh.org>:
> > [...]
> > > > Anyway, with all that done, I'm through with nitpicking. I think you
> > > > should threaten to apply my re-indented version of your patch. Give an
> > > > ultimatum of a few days, and make sure Reimar has a chance to respond if
> > > > he wants, since he had an opinion on channel reordering long ago. If
> > > > everybody ignores you, apply.
> > >
> > > I'd like to, but, before and after I post this patch, I ever discussed
> > > with Reimar and other developers with it on irc, all current patches
> > > for channel order fix were considered as hacks, for hacks, they does
> > > not care performance so much. I don't known whether the opinion
> > > changed now, so I have to ask Reimar about this, which one of our
> > > patches could be acceptable to commit or after some additional
> > > adoptions, Reimar?
> >
> > I do not care much what will be applied, though I would prefer it if
> > most of the new code is confined to the problematic decoders.
>
> I'm not sure, is that mean the Giacomo's patch and my patch is acceptable?
> If so, I still has few questions for my patch:
> 1. Where should my two reorder file (.c .h) be put, root dir or libaf dir?

Now I move the two file into libaf.

> 2. Since the function not only reorder when copying, should the name
> reorder_channel.c/.h be used instead?

Renamed to reorder_ch.c/.h

And also re-indented modified codes as Corey suggested.

Here's the current version patch. If no objections ( I assume Reimar
did not object my patch in last his post in this thread.) , I will
commit this in 5 days.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reorder_func7.diff
Type: text/x-diff
Size: 43805 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071130/48d54fc2/attachment.diff>