[MPlayer-dev-eng] [PATCH] [TEST FUNC] Multi-channel reorder function
ulion2002 at gmail.com
Thu Nov 29 11:38:15 CET 2007
2007/11/29, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> On Thu, Nov 29, 2007 at 10:12:10AM +0800, Ulion wrote:
> > 2007/11/29, Corey Hickey <bugfood-ml at fatooh.org>:
> > > Anyway, with all that done, I'm through with nitpicking. I think you
> > > should threaten to apply my re-indented version of your patch. Give an
> > > ultimatum of a few days, and make sure Reimar has a chance to respond if
> > > he wants, since he had an opinion on channel reordering long ago. If
> > > everybody ignores you, apply.
> > I'd like to, but, before and after I post this patch, I ever discussed
> > with Reimar and other developers with it on irc, all current patches
> > for channel order fix were considered as hacks, for hacks, they does
> > not care performance so much. I don't known whether the opinion
> > changed now, so I have to ask Reimar about this, which one of our
> > patches could be acceptable to commit or after some additional
> > adoptions, Reimar?
> I do not care much what will be applied, though I would prefer it if
> most of the new code is confined to the problematic decoders.
I'm not sure, is that mean the Giacomo's patch and my patch is acceptable?
If so, I still has few questions for my patch:
1. Where should my two reorder file (.c .h) be put, root dir or libaf dir?
2. Since the function not only reorder when copying, should the name
reorder_channel.c/.h be used instead?
3. I'm not familar with inline function and not sure whether inline
function can be optimized same with macro version, so is current macro
version acceptable for commit?
More information about the MPlayer-dev-eng