[MPlayer-dev-eng] [PATCH] [TEST FUNC] Multi-channel reorder function

[Corey Hickey]

Ulion wrote:
> Cleaned up. How about current version?

Closer, but some of the indentation didn't quite match up. The attached
version should be more consistent; check and much sure I didn't mess it up.

One thing in particular--when you want something indented like this:

	reorder_channel_copy(src, AF_CHANNEL_LAYOUT_MPLAYER_5CH_DEFAULT,
	                     dest, AF_CHANNEL_LAYOUT_WAVEEX_5CH_DEFAULT,
	                     max_size / 2, 2);

	<---tab to here, and then spaces

...you can't use additional tabs to make src, dest, and max align
vertically, since a tab is not a fixed number of spaces; people
configure their editors differently. Use one or more tabs to align with
the left end of reorder_channel_copy, and then spaces to indent further.
Hopefully your mail reader doesn't mangle my example... :)


Anyway, with all that done, I'm through with nitpicking. I think you
should threaten to apply my re-indented version of your patch. Give an
ultimatum of a few days, and make sure Reimar has a chance to respond if
he wants, since he had an opinion on channel reordering long ago. If
everybody ignores you, apply.

-Corey
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: reorder_func6_reindent.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071128/1e9a18b8/attachment.asc>