[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

Ulion ulion2002 at gmail.com
Tue Nov 27 01:35:39 CET 2007


2007/11/27, Jindrich Makovicka <makovick at gmail.com>:
> On Mon, 26 Nov 2007 23:31:29 +0800
> Ulion <ulion2002 at gmail.com> wrote:
>
> > 2007/11/25, Ulion <ulion2002 at gmail.com>:
> > > 2007/11/25, Reimar Döffinger
> > > <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > > Hello,
> > > > On Sat, Nov 24, 2007 at 12:27:13PM -0500, Rich Felker wrote:
> > > > > However I maintain that calling commands via the shell is
> > > > > fundamentally risky and bogus. Use fork(2) and exec*(2)
> > > > > functions.
> > > >
> > > > Can you maybe check the patch
> > > > "fake unrarlib using RAR executable" from April 17th, 2005?
> > > > I do not even know if it applies, but if people really so much
> > > > want this feature that patch seems much more elaborate than this
> > > > and probably could be cleaned up to be okay.
> > >
> > > That one looks did better than my this one, since that one has
> > > chance to be ok, I will switch work to that one.
> >
> > OK, here's the updated patch base on the old patch, also tested work
> > on MinGW win32.
>
> The "-p-" option could be added to the extraction options to prevent
> lockups on encrypted files. You can also use my current email address in
> the credits.

It's amazing receive you reply, Jindrich, thanks for your patch and suggestion.
Here's updated patch.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unrar_exec4.diff
Type: text/x-diff
Size: 16788 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071127/f58afed1/attachment.diff>


More information about the MPlayer-dev-eng mailing list