[MPlayer-dev-eng] [PATCH] [TEST AFILTER] Encode ac3 at runtime using lavc

Ulion ulion2002 at gmail.com
Sat Nov 24 17:08:02 CET 2007


2007/11/24, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > +    static const int default_sample_rate[AC3_MAX_CHANNELS+1] = \
> > +        {0, 96000, 192000, 256000, 384000, 448000, 448000};
>
> That '\' is pointless.
>
> > +        s->expect_len    = AC3_FRAME_SIZE * data->nch * data->bps;
> > +        if (s->add_iec61937_header)
> > +            af->mul = (double)AC3_FRAME_SIZE * 2 * 2 / s->expect_len;
> > +        else
> > +            af->mul = (double)AC3_MAX_CODED_FRAME_SIZE / s->expect_len;
>
> still think it is better to always add the headers and add removal code
> to ao_pcm if desired. That is assuming that the padding 0 do not hurt,
> but I doubt they will.

removal code in ao_pcm is a plan, but indeed you will find it's a
little hard to do that, and I'm not ready to do that by now.
I'm sorry the second sentence you said 'That is assuming that the
pendding 0 do not hurt', what's the 'That' mean? I didn't figure it
out.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list