[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Zuxy Meng]

Hi,

2007/11/24, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Nov 24, 2007 at 02:50:59PM +0800, Ulion wrote:
> > We already discussed the libunrar patch, that was linked to mplayer so
> > it's rejected.
> > But we can safely use external decompress tool 'unrar' for this purpose.
>
> Please before writing a patch search the archives carefully, there were
> at least three different attempts in the past, we do not need another
> flawed implementation of the same thing, we need a proper one.
> And honestly a proper solution will most likely have to clean up the
> _unspeakable utter and complete mess_ the current code is (the one using
> unrarlib, well, actually unrarlib itself probably is a mess as well).

That's because the unrar source is written in C++ and is a mess at the
first place.

> An additional point is that I am not at all too happy about spending
> time improving support for a proprietary format, but not
> reverse-engineering it but instead jumping through all kinds of hoops
> while not supporting any of the opensource compression formats that
> would work as well if not better.

True. But the reality is that most vobs are compressed with RAR
instead of zip, zlib, etc, a "tradition" started by 0day guys and
followed by others; and that's the reason why people are keeping
asking for and submitting such patches to mplayer IMHO.

Maybe we can stop the frequent flaming by adding an item in our FAQ
and ask those who want RARv3 support to search the archive and apply
the patch in their private build themselves? I know some people are
using mine :-)

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6