[MPlayer-dev-eng] [PATCH] m_property.c - please give feedback

Chris Welton electrostatic_1 at yahoo.com
Sat Nov 24 10:25:09 CET 2007


There are a lot of compiler warnings from "discards
qualifiers from pointer target type" and " assignment
from incompatible pointer type" etc..

I started out with this one file and tried to fix all
of the warnings while simultaneously removing
unnecessary casts (through correct assignment). The
only cast left in this area of code is to (void *) for
sending a struct pointer an anonymous function
pointer. (Having an anonymous  function pointer there
in the first place was not my idea.)

Please let me know if you think this is an acceptable
way. I am open to learning better ways if you have any
suggestions.

Chris


      ____________________________________________________________________________________
Be a better sports nut!  Let your teams follow you 
with Yahoo Mobile. Try it now.  http://mobile.yahoo.com/sports;_ylt=At9_qDKvtAbMuh1G1SQtBI7ntAcJ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: m_property.c.fixed_casts.diff
Type: application/octet-stream
Size: 1015 bytes
Desc: 1794184300-m_property.c.fixed_casts.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071124/6b02a58c/attachment.obj>


More information about the MPlayer-dev-eng mailing list