[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Rich Felker]

On Sat, Nov 24, 2007 at 02:50:59PM +0800, Ulion wrote:
> Hello,
> 
> We already discussed the libunrar patch, that was linked to mplayer so
> it's rejected.
> But we can safely use external decompress tool 'unrar' for this purpose.
> 
> How to use this patch:
> 1. compile your mplayer with this patch applied.
> 2. goto ftp://ftp.rarlabs.com/rar/ , download newest unrar source
> (unrarsrc-*)and build unrar for your machine.
> 3. put the unrar binary file into same dir with your mplayer binary.
> 
> That's all, have fun.

This patch is full of dangerous vulns and is thereby rejected. It's
also a bad approach. If access to rar'd subs is really so important
(huh? I never understood the point, just unrar them before burning
your cds...) then please read and document the unrar source so that
someone can make a cleanroom free replacement.

Rich