[MPlayer-dev-eng] [PATCH] Make stream support http redirect
Ulion
ulion2002 at gmail.com
Fri Nov 23 13:19:09 CET 2007
2007/11/23, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Fri, Nov 23, 2007 at 01:08:44PM +0800, Ulion wrote:
> > 2007/11/20, Ulion <ulion2002 at gmail.com>:
> > > 2007/11/20, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > > > Index: stream/stream.h
> > > > > ===================================================================
> > > > > --- stream/stream.h (revision 25083)
> > > > > +++ stream/stream.h (working copy)
> > > > > @@ -48,6 +48,7 @@
> > > > > #define STREAM_UNSUPPORTED -1
> > > > > #define STREAM_ERROR 0
> > > > > #define STREAM_OK 1
> > > > > +#define STREAM_REDIRECTED -2
> > > >
> > > > Seems like a weird place to put it, unless you can use 2 for it, I'd put
> > > > it before the UNSUPPORTED?
> > > > Apart from that, while the stream.c part unfortunately is a bit complex
> > > > I did not see any problems (but I did not take time for a real review
> > > > and am too tired for it anyway).
> > > >
> > >
> > > It need less than zero, so I made it value -2, the place is not
> > > suitable, I will move it up as you suggested.
> > >
> >
> > Then, is the moved up version commitable, Reimar?
>
> Sure, I still do not have any objections (assuming it was tested,
> because I did not).
Sure, then I will apply this patch in 3 days if no objections.
--
Ulion
More information about the MPlayer-dev-eng
mailing list