[MPlayer-dev-eng] [PATCH] [TEST AFILTER] Encode ac3 at runtime using lavc

[Reimar Döffinger]

Hello,
On Thu, Nov 22, 2007 at 12:34:03AM +0800, Ulion wrote:
[...]
> > So the only thing that is missing IMO is documenting that the AC3/DTS
> > etc. formats actually mean those wrapped in IEC-headers.
> 
> Currently yes, but it's better confirm what ao_mpegpes.c mean to use
> the AC-3 format.

The problem is that the current filter chain has no notion of packets/frames
(and thus can not guarantee to keep the boundaries), but even ao_mpegpes.c
almost needs the data split this way.
So unless you want to "fix" the whole filter stuff to use packets
(questionable if this is even such a good idea) we have either the
option of supporting only IEC and those aos who need it must remove it
(while still using the info to split by frames), or we support non-IEC
and those aos probably have to implement packetizing.
Which brings me to why I think that it is _pointless_ to support
non-IEC, and thus we need no flag to indicate it.

[...]
> btw: any suggestion for generate the last ac3 frame of at the audio
> track end, it has not enough bytes to triger the encode action in
> current code.

If nothing else, use an AF_CONTROL that indicates the end of the audio
stream.

Greetings,
Reimar Döffinger