[MPlayer-dev-eng] [PATCH] [TEST AFILTER] Encode ac3 at runtime using lavc

[Diego Biurrun]

On Tue, Nov 20, 2007 at 04:38:13PM +0800, Ulion wrote:
> 2007/11/20, Ulion <ulion2002 at gmail.com>:
> > >
> > > Here's the fixed version. Still need peoples familar with encoder or
> > > ac3 or audio filter give suggestions and helps.
> >
> > Missed attachment.
> 
> Sorry for my mistake in Makefile, fix again.
> 
> --- DOCS/man/en/mplayer.1	(revision 25106)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -4695,6 +4695,30 @@
> +.B lavcac3enc[=tospdif[:bitrate[:minchn]]]
> +Encode multi-channel audio to AC-3 at runtime using libavcodec.
> +Supports input 16-bit little-endian or big-endian format, max 6 channels.

input formats

Try not to use abbreviations, i.e. max --> maximum

> +Need to specify '\-channels N' to make the decoder decode audio into N channels,
> +then the filter can encode the N channels input to AC-3.

"You need to", please keep lines below 80 characters.

> +.IPs <tospdif>
> +Output raw AC-3 stream if zero or not set,
> +output to S/PDIF for passthrough when <tospdif> is set non-zero.
> +.IPs <bitrate>
> +The bitrate to encode the A??-3 stream, default 192kbits for 2ch,

Spurious (Chinese?) character, avoid abbreviations.

> +384kbits for more channels if not set.
> +Either set it with 384 or 384000 to got 384kbits.

s/with/to/, s/got/get/

> +.IPs <minchn>
> +Minimum channel number of the input audio to use this filter (default: 5).
> +If input channel number is less than <minchn>, filter will detach itself.

If the input channel number is less than <minchn>, the filter will
detach itself.

> --- libaf/af_lavcac3enc.c	(revision 0)
> +++ libaf/af_lavcac3enc.c	(revision 0)
> @@ -0,0 +1,289 @@
> +/*
> + * Audio filter for encoding AC-3 stream at runtime using libavcodec.

Audio filter for runtime AC-3 encoding with libavcodec

> +#ifndef AC3_FRAME_SIZE
> +#define AC3_FRAME_SIZE 1536
> +#endif

Is this needed?  Where else is it defined?

Diego