[MPlayer-dev-eng] [PATCH] Multi-channel reorder (aac, pcm and ac3)

Ulion ulion2002 at gmail.com
Sun Nov 18 20:10:16 CET 2007


2007/11/17, Giacomo Comes <comes at naic.edu>:
> Here is (hopefully) the final try to include the channels reordering
> code in MPlayer.
> There has been several (different) attempt to fix the problem and none
> of them fully satisfies the developers (planar formats will do, but
> none appears to be intrested in implementing that).
>
> People intrested can check the following threads for a refresh:
>
> [PATCH] channel reordering for 6ch audio
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-July/044844.html
>
> [RFC] 6-channel AAC and channel reordering
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-October/046963.html
>
> [PATCH] audio channel remapping
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2006-November/047269.html
>
> [PATCH] [TEST FUNC] Multi-channel reorder function
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-November/054820.html
>
> The patches I'm submitting are an extension of the ones submitted by
> Alexander Ponyatikh and it seems they are the one with higher probability to
> be accepted.
>
> Please let's discuss then now and find a final agreement.
>

 	int n;
+	if (encoder->params.channels == 6 || encoder->params.channels == 5 &&
+	  !strcmp(lavc_acodec->name,"ac3") || !strcmp(lavc_acodec->name,"libfaac") ) {

should be if ( ( == || == ) && (!strcmp || !strcmp))

-- 
Ulion



More information about the MPlayer-dev-eng mailing list