[MPlayer-dev-eng] [PATCH] Make stream support http redirect

[Ulion]

2007/11/18, Gianluigi Tiesi <mplayer at netfarm.it>:
> On Sun, Nov 18, 2007 at 09:37:39AM +0800, Ulion wrote:
> > 2007/11/16, Onur Küçük <onur at delipenguen.net>:
> > >
> > > On Fri, 2 Nov 2007 17:28:39 +0800
> > > Ulion <ulion2002 at gmail.com> wrote:
> > >
> > > > Hello,
> > > >
> > > > There's a reported bug
> > > > http://bugzilla.mplayerhq.hu/show_bug.cgi?id=927 The problem is the
> > > > http module of stream will treat all redirect url as http protocol,
> > > > so the redirected mms:// url is handled incorrectly. This patch give
> > > > a chance to handle the redirected url in correct way.
> > >
> > >  This patch breaks playing of these address
> > >
> > > http://www.shoutcast.com/sbin/shoutcast-playlist.pls?rn=227477
> > > http://www.shoutcast.com/sbin/shoutcast-playlist.pls?rn=816285
> > > http://www.shoutcast.com/sbin/shoutcast-playlist.pls?rn=587297
> > > http://www.shoutcast.com/sbin/shoutcast-playlist.pls?rn=778610&file=filename.pls
> > > http://www.shoutcast.com/sbin/shoutcast-playlist.pls?rn=4607&file=filename.pls
> > >
> >
> > Thank you, I missed one 'goto out', did not set the return value
> > correctly. Here's the fixed patch, also deny redirect from http:// to
> > file:// as a little security feature.
> >
>
> if redirection is recursive you should put a limit on
> the number of redirections or it will become a dos
>

You are right, but that's another bug of stream/http.c, it did not
detect the redirect loop, it always redirect. Anyone consider fix that
bug?

-- 
Ulion