[MPlayer-dev-eng] [Patch 1/2] dvd_set_speed fixes/addons

[Reimar Döffinger]

Hello,
On Fri, Nov 16, 2007 at 09:30:58PM +0100, Sebastian Kemper wrote:
> attached patch fixes some glitches in dvd_set_speed() (stream_dvd.c).
> 
> - unsigned speed to int speed (because restoring the initial speed means
>   to set speed=-1)

-1 is just a way to write the "all bits one" special value, I don't
think it makes sense to use signed here.

> - use the correct ATAPI command length for SET STREAMING (12 bytes); at
>   least libata (for now anyways) won't let commands through when the
>   command length is wrong ("old" ATA is more forgiving and cuts the last
>   4 bytes)

Applied.

> - add a check to make sure the device really is an SG device (taken from
>   sg_simple2.c)
>   I'm not sure you guys like the printf() but I don't really want to
>   dive into mplayer's message system

Dropped.

> - add close(fd)'s where feasible
> - add a missing return

Fixed differently.

Greetings,
Reimar Döffinger